docs: drop copied Robidoux Sharp comment from Spline - #3170
Open
FirmaSpring wants to merge 1 commit into
Open
Conversation
CubicResampler.Spline had a second XML summary copied from RobidouxSharp. The field is the B-spline (B=1, C=0) kernel, so only the spline summary should remain. Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CubicResampler.Splineis documented twice. The second XML<summary>is a copy of the Robidoux Sharp comment and does not describe the spline kernel (B=1,C=0).IntelliSense / generated docs for
Splinewould show the wrong algorithm name.Solution
Remove the copied Robidoux Sharp summary so
Splinekeeps only the spline documentation.Verification
The remaining comment matches the
Spline = new(2, 1, 0)construction.RobidouxSharpstill has its own summary above.Checked open PRs; none touch this file for this comment.