docs: fix Samples repository path in README - #3169
Closed
FirmaSpring wants to merge 1 commit into
Closed
Conversation
## Problem The README samples link points at a path that no longer exists: https://github.com/SixLabors/Samples/tree/main/ImageSharp A GET with redirects returns 404. The samples repo now lives under `SixLabors.Samples.ImageSharp`. ## Solution Point the README at the current samples folder. ## Verification ``` curl -sL -o /dev/null -w "%{http_code} %{url_effective}" -A "Mozilla/5.0" \ "https://github.com/SixLabors/Samples/tree/main/ImageSharp" # 404 https://github.com/SixLabors/Samples/tree/main/ImageSharp curl -sL -o /dev/null -w "%{http_code} %{url_effective}" -A "Mozilla/5.0" \ "https://github.com/SixLabors/Samples/tree/main/SixLabors.Samples.ImageSharp" # 200 https://github.com/SixLabors/Samples/tree/main/SixLabors.Samples.ImageSharp ``` Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
Author
|
Closing as duplicate of #3168 (opened a minute earlier from the same account) which fixes the same Samples repository path. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The README samples link points at a path that no longer exists:
https://github.com/SixLabors/Samples/tree/main/ImageSharp
A GET with redirects returns 404. The samples repo now lives under
SixLabors.Samples.ImageSharp.Solution
Point the README at the current samples folder.
Verification