Remove deprecated POS session staffMemberId in 2026-10 - #4685
Closed
IHu04 wants to merge 2 commits into
Closed
Conversation
Assisted-By: devx/0b5f33af-6704-45ef-aa58-1e9552f7971e
IHu04
force-pushed
the
isaac/remove-pos-session-staff-member-id-2026-10
branch
from
September 11, 2026 15:19
9003e7c to
26142bc
Compare
Assisted-By: devx/0b5f33af-6704-45ef-aa58-1e9552f7971e
Contributor
Author
|
Replaced by #4686 with identical changes consolidated into a single commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.currentSession.staffMemberIdproperty from the POSSessiontype for 2026-10. Use the reactivesession.staffMembersignal instead.session.staffMemberIdtype and mock value.BaseDatashared theSessiontype, so it now explicitly retains the optional snapshot field.Testing
yarn build— passedyarn test -- packages/ui-extensions-tester/— 12 suites, 110 tests passedyarn type-check— passednpx tsc --project packages/ui-extensions-tester/tsconfig.typecheck.json— passed, including test files and negative type assertionsnpm run typecheck && npm testin all fourexamples/testing/*projects — passed (15 tests)yarn lint— formatting passed; ESLint reports 8 errors only in unrelated build-generatedpackages/ui-extensions/checkout/preact.jsandpackages/ui-extensions/customer-account/preact.js. ESLint passed for changed TypeScript files and for the repository excluding those two generated entry points.Scope / follow-up
2026-10-rc; 2026-07 and earlier published types are unchanged.unstable, butdocumentation/versions-and-deploys.mdsays that branch is deprecated, frozen at 2025-07, and must not receive new work.instanceReloadedupdate still require a separate Shopify/extensibility change. This PR does not change the real POS runtime.Related