Repository navigation
Paginate commit statuses from GitHub - #1514
Open
rafayqayyum wants to merge 1 commit into
Open
rafayqayyum wants to merge 1 commit into
rafayqayyum wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #993.
Commit#refresh_statuses!still only fetched one page of 100 statuses, the hotfix from #989. GitHub's statuses endpoint returns every status event, not just the latest per context, so a commit with ~50 contexts (pending + success each) already exceeds a page and the rest were dropped.This follows
last_response.rels[:next]throughhandle_github_redirections, the same approach aspaginated_check_runs. One difference: it reads the next link before storing a page's statuses, so a GitHub call made while storing them (e.g. from a hook) can't replacelast_responseand stop pagination early.Tests: a two-page test modelled on the check runs one, the existing statuses test now stubs
last_response, and the merge request refresh test expectslast_responsetwice since statuses read it too. CHANGELOG entry added under Unreleased.