Repository navigation
Avoid assigning Liquid context to arbitrary variables - #2137
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Liquid needs the rendering context before
to_liquidfor context-aware drops. Assigning it to any object that exposescontext=can call an unrelated application setter, such as a read-only Active Record attribute, and make rendering fail. Limit the assignment toLiquid::Dropinstances that expose the writer, and add a regression test. Fixes #1930.rake testpassed in lax, strict and strict2 modes: the base suite ran 1,063 tests/2,542 assertions and the integration suite 803/1,917 per mode. RuboCop 1.82.1 with rubocop-shopify 2.18.0 passed all 160 files;git diff --checkpassed.bundle exec rakewas not run because Bundler stalled while fetching theShopify/liquid-specGit dependency.