Repository navigation
Stop rendering after a Liquid nesting limit error - #2136
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Preserve template and line metadata while stopping a render on StackLevelError. This avoids continuing through exponentially branching recursive partials after the nesting guard is reached. Fixes Shopify#1435
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recursive includes can branch exponentially after the nesting limit because lax rendering converts
StackLevelErrorto inline text and continues through sibling nodes. This change records the template and line context, then raises the error so rendering stops at the first limit breach. A low-depth regression test covers the branching include case.bundle exec rakeandbundle exec rake specpass on Ruby 4.0.2. Fixes #1435.