Repository navigation
Stabilize the liquid-spec CI baseline - #164
Merged
Merged
Conversation
Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
liquid-spec's main CI can fail before it reaches the reference suite: the JSON-RPC timeout test gives subprocess handshakes only 100ms, and the feature-coverage gate has six existing uncovered Shopify tags with no recorded baseline.
This keeps the intentional stalled request at 100ms while giving process initialization and restart one second. It also records the six existing feature-coverage gaps as known debt. New uncovered tags still fail the gate, and a baseline entry fails once its feature gains reference coverage.
The baseline changes only the timeout test and feature-coverage check. In a clean v5.13 checkout, the pre-push gate passes with 169 tests and 741 assertions; the reference adapter passes 5,020 specs, and the coverage check reports the six acknowledged tags.