Add captured self specs for scope across render boundaries#145
Open
karreiro wants to merge 1 commit into
Open
Conversation
684002d to
4eecfb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new conformance specs in
specs/liquid_ruby/bare_bracket_self.ymlthat define how a capturedselfbehaves when crossing{% render %}boundaries. The first spec shows thatselfcaptured in the outer template continues to resolve through the original scope both before and inside the rendered snippet, while a freshly readselfinside the snippet resolves to the snippet's own scope (outer|outer|snippet). The second spec extends this across three nested renders, proving that each level's capturedselfremains stable as render depth increases, while a freshselfin the innermost snippet sees its own scope (1|1/2|1/2/3).These specs belong in liquid-spec because this behavior is a cross-implementation contract, not an implementation detail. They pass on both the Ruby reference adapter and the liquid-vm adapter, replacing prior liquid-vm-only integration tests. The corresponding liquid-vm PR updates the spec reference and removes the duplicated tests in favor of these shared conformance specs.