[Security] Harden devConsoleAssetsMiddleware against path traversal#7619
Conversation
Hardens the dev console asset middleware against path traversal by resolving the requested asset path and verifying it is a subpath of the intended root directory.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
Hardens the dev console asset middleware against path traversal by resolving the requested asset path and verifying it is a subpath of the intended root directory. Also cleans up mocks in tests to satisfy linting rules.
1 participant
WHY are these changes introduced?
Hardens the dev console asset middleware against path traversal vulnerabilities to ensure that only intended assets within the designated root directory can be served.
WHAT is this pull request doing?
Implements a path traversal guard in
devConsoleAssetsMiddlewareby resolving the requested asset path and verifying it remains within the intended base directory using a subpath check.How to test your changes?
CI
Post-release steps
(Empty)
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 8155965175824118762 started by @gonzaloriestra