Skip to content

chore: pin quicktype from pnpm#204

Merged
kiftio merged 2 commits into
mainfrom
05-25-cleanup_quicktype_scripts
Jun 2, 2026
Merged

chore: pin quicktype from pnpm#204
kiftio merged 2 commits into
mainfrom
05-25-cleanup_quicktype_scripts

Conversation

@westeezy

@westeezy westeezy commented May 25, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Update quicktype to download from npm so we can pin a version safely and rely on that version. brew only serves latest

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

westeezy commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.59% (316/345) 87.25% (178/204) 100% (82/82)

@westeezy westeezy changed the base branch from 05-25-regenerate_models to graphite-base/204 May 25, 2026 22:28
@westeezy westeezy force-pushed the 05-25-cleanup_quicktype_scripts branch from dc3a9a8 to 38101a6 Compare May 25, 2026 22:29
@westeezy westeezy force-pushed the graphite-base/204 branch from 9338dfe to 29dd3d2 Compare May 25, 2026 22:29
@westeezy westeezy changed the base branch from graphite-base/204 to 05-25-schema_update_scripts May 25, 2026 22:29
@westeezy westeezy marked this pull request as ready for review May 25, 2026 23:11
@westeezy westeezy requested a review from a team as a code owner May 25, 2026 23:11
@westeezy westeezy force-pushed the 05-25-cleanup_quicktype_scripts branch from 38101a6 to cf2e2d0 Compare May 25, 2026 23:34
@westeezy westeezy force-pushed the 05-25-schema_update_scripts branch 2 times, most recently from 67ff7da to f6df98b Compare May 26, 2026 00:15
@westeezy westeezy force-pushed the 05-25-cleanup_quicktype_scripts branch from cf2e2d0 to 63c1451 Compare May 26, 2026 00:15
@westeezy westeezy changed the base branch from 05-25-schema_update_scripts to graphite-base/204 May 26, 2026 00:39
@westeezy westeezy changed the base branch from graphite-base/204 to 05-25-schema_provinence May 26, 2026 00:39
@westeezy westeezy force-pushed the 05-25-schema_provinence branch from f6df98b to 95b7be7 Compare May 26, 2026 16:16
@westeezy westeezy force-pushed the 05-25-cleanup_quicktype_scripts branch from 63c1451 to 83d5009 Compare May 26, 2026 16:16
@westeezy westeezy changed the base branch from 05-25-schema_provinence to graphite-base/204 June 1, 2026 00:58
@westeezy westeezy force-pushed the 05-25-cleanup_quicktype_scripts branch from 83d5009 to 4bbf4ca Compare June 1, 2026 01:10
@westeezy westeezy force-pushed the graphite-base/204 branch from 95b7be7 to e99a519 Compare June 1, 2026 02:04
@westeezy westeezy changed the base branch from graphite-base/204 to main June 1, 2026 02:04
westeezy and others added 2 commits June 2, 2026 13:45
Pin quicktype as a protocol-local pnpm dependency and update protocol codegen to use that binary instead of a globally installed package.
@kiftio kiftio force-pushed the 05-25-cleanup_quicktype_scripts branch from 4bbf4ca to da279d8 Compare June 2, 2026 12:50
@kiftio kiftio merged commit 4bb6ba1 into main Jun 2, 2026
26 checks passed
@kiftio kiftio deleted the 05-25-cleanup_quicktype_scripts branch June 2, 2026 13:04
@markmur markmur added the #gsd:50662 Rebase Checkout Kit on UCP label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants