Add common_javacopts to make_scala_rules call site - #1867
Merged
Merged
Conversation
The parameter is mandatory since joernio/bazel_tooling#1 so that the javacopts for the Java portion of mixed Java/Scala targets are explicit at every call site. Values mirror java_common_opts in bazel/java.bzl. Requested in the review of ShiftLeftSecurity/java2cpg#1106.
max-leuthaeuser
force-pushed
the
max/bazel-tooling-javacopts
branch
from
September 23, 2026 10:03
ccd6511 to
6fae599
Compare
ml86
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter is mandatory since joernio/bazel_tooling#1 so that the javacopts for the Java portion of mixed Java/Scala targets are explicit at every call site. Values mirror
java_common_optsinbazel/java.bzl.Requested in the review of https://github.com/ShiftLeftSecurity/java2cpg/pull/1106.