Skip to content

Change INDEX property default value to -2.#1856

Merged
ml86 merged 3 commits into
masterfrom
markus/switchIndexDefaultValue
Jun 2, 2026
Merged

Change INDEX property default value to -2.#1856
ml86 merged 3 commits into
masterfrom
markus/switchIndexDefaultValue

Conversation

@ml86
Copy link
Copy Markdown
Contributor

@ml86 ml86 commented Jun 2, 2026

Previously INDEX property default value was -1 now it is -2.
We do this to avoid representation collisions if frontends happen to not
set this property. See code comment for further details.

Previously INDEX property default value was -1 now it is -2.
We do this to avoid representation collisions if frontends happen to not
set this property. See code comment for further details.
@ml86 ml86 requested review from SuperUserDone, bbrehm and maltek June 2, 2026 09:58
Comment thread schema/src/main/scala/io/shiftleft/codepropertygraph/schema/Base.scala Outdated
@SuperUserDone
Copy link
Copy Markdown
Contributor

…se.scala

Co-authored-by: maltek <1694194+maltek@users.noreply.github.com>
@ml86
Copy link
Copy Markdown
Contributor Author

ml86 commented Jun 2, 2026

@SuperUserDone The VarArgParameterPass is fine. The -1 encoding of "method has no vararg parameter is independent of the INDEX default value.

@ml86 ml86 merged commit 3021531 into master Jun 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants