Keep instance passwords out of pytest tracebacks - #163
Merged
Merged
Conversation
Pytest prints test arguments in failure tracebacks, so a failing L1 test printed its snow_instance_entry, admin password included, into the public Actions log (run 35916033360). Pool entries in the tests are now a dict subclass whose repr redacts the password. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest prints a failing test's arguments in its traceback. When
test_cheat[...workarenapublic26...-CreateChangeRequestTask]failed in run 35916033360, it printedsnow_instance_entry, instance 26's admin password included, into the public Actions log. That was the only leak in the run's full log.The pool entries in
test_task_general.py,test_snow_instance.pyandtest_instance_preconditions.pyare now aRedactedInstanceEntry(adictsubclass intests/utils.py) whosereprshows the URL and'<redacted>'. Lookups are unchanged.Not handled here: the password already in that run's log. It should be rotated, and the run's logs deleted.
Testing
RedactedInstanceEntryprints'<redacted>'.test_snow_instance.py: 12 passed. Pool health: 87 passed.test_task_general.pycollects (99 tests). Fast PR suite: 30 passed.black==24.2.0 --checkis clean.🤖 Generated with Claude Code