Fix races and a broken test surfaced by the first nightly shard - #162
Merged
Merged
Conversation
- navigation: always take the first menu item matching the label. The row is aria-labelledby its link, so there are always two matches; checking count() before the menu finished rendering let click() hit a strict-mode violation under load (20 L2 failures in run 35916033360). - private_tasks: only wait for networkidle when the page is actually read for the user's sys_id. L3 always passes user_sys_id, and the wait timed out after 30s under load (13 L3 failures). - test_filter_list_task: encode the "?" of the classic target URL so the query reaches the list; the test failed deterministically before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first nightly run of
instance_pool_ci.yml(run 35916033360) had 34 shard failures. None were caused by #160/#161's logic: two load races at-n 20and one test that fails every time.aria-labelledbyits link. The cheat calledcount()before the filtered menu had finished loading, got ≤1, skipped.first, andclick()then hit a strict-mode violation. It now always takes.first, which is what it already did whenever the menu had loaded.create_private_task_and_get_sys_idwaited fornetworkidle(30s timeout) even whenuser_sys_idis passed, which L3 always does. The wait is now only in the branch that reads the page.test_filter_list_task(1 failure, fails every time). The?of the classic target URL wasn't encoded, so the query never reached the list ("There are no filters yet."). Locally it went from 9/10 failing to 10/10 passing.Testing
WORKARENA_TEST_SEED=266,-n 5: 32 passed. The remaining one failed later, in the form cheat (g_formundefined inform.py:_get_fields). It is a separate intermittent race under parallel load and passed 2/2 run on its own. Not addressed here.CreateChangeRequestTaskfailure on instance 26 passes locally. The log doesn't show the validation message, so it's not addressed here.🤖 Generated with Claude Code