fix: recognize git -c in SRT clone test stub / fix: 让 SRT clone 测试夹具识别 git -c - #3548
Draft
edwingao28 wants to merge 1 commit into
Draft
edwingao28 wants to merge 1 commit into
edwingao28 wants to merge 1 commit into
Conversation
Match main #3443 so the fixture stages checkout when setup_srt_slurm invokes `git -c advice.detachedHead=false clone`. 识别 git -c 选项,使 SRT 单节点启动测试夹具在 clone 前正确创建 checkout。 Co-authored-by: Wenyao Gao <edwingao28@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the InferenceX #3379 CPU Tests failure with the smallest justified fix already landed on
mainin #3443.The CI failure was not caused by the B300 native SRT power coverage diff. It is launcher/test contract drift from #3410 (
git -c advice.detachedHead=false clone ...) that the PR head absorbed when it merged then-main(b7bff8bc) before #3443 updated the git stub. The stub only matched$1 == clone, so staging never createdcheckout/, and everytest_pool_launcher_stages_artifacts_and_propagates_failure[...]case failed (missing checkout /point-identity.json).This draft repair PR targets owned branch
fix/qwen35-b300-powerx-coverageso ownership of #3379 is preserved.Root cause
5c9fc7e6into then-baseb7bff8bc(merge SHAb61f0c91)5c9fc7e6main(#3443)Fix
One-line change in
utils/test_srt_single_node.pygit stub:Verification (CPU-only)
No GPU runs. No remote CI reruns for diagnosis.
Main conflict status
Owned PR #3379 remains DIRTY/CONFLICTING vs current
main(large project layout migration #3525+). This repair does not resolve that rebase; it only clears the CPU Tests contract failure on the current #3379 lineage. After merging this into #3379, a separate main reconcile is still required before #3379 can be a merge candidate.AI model disclosure
originalModelNamefrom run-info): investigation, local repro, patch, verification, and PR preparation.中文
摘要
用已合入
main(#3443)的最小修复清除 InferenceX #3379 的 CPU Tests 失败。失败并非 B300 native SRT power 覆盖改动本身引起,而是 #3410 将 clone 改为
git -c advice.detachedHead=false clone ...后,测试夹具仍只匹配$1 == clone,导致无法 stagingcheckout/。本草稿修复 PR 指向已有分支fix/qwen35-b300-powerx-coverage,不接管 #3379 所有权。验证
修复前 2 个代表用例失败;修复后整组
test_pool_launcher_stages_artifacts_and_propagates_failure共 26 项通过。未使用 GPU,未为诊断重跑远程 CI。与 main 冲突
#3379 相对当前
main仍冲突(含 #3525 目录迁移)。本 PR 不解决 rebase,只修复当前谱系上的 CPU 测试契约问题。AI 模型披露