-
Notifications
You must be signed in to change notification settings - Fork 287
Use DSpark6 for B200 DSV4 SGLang AgentX / B200 DSV4 SGLang AgentX 使用 DSpark6 #2821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nvpohanh
wants to merge
2
commits into
main
Choose a base branch
from
dsv4-fp4-b200-sglang-agentic-hicache-dspark-0813
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−12
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 (optional) These three search-space arms now set spec-decoding: draft_model, the first real usage of that value in nvidia-master.yaml, but configs/ci-priority.yaml's spec-decoding adjustments only list mtp/eagle/eagle3 (utils/ci_priority.py:163 does adjustments['spec-decoding'].get(value, 0)). CI priority scoring for this recipe's jobs silently drops by 0.75 (previously granted under spec-decoding: mtp) versus base branch, deprioritizing them in the run-sweep/e2e-tests/profile queues with no error. Fix: add draft_model to configs/ci-priority.yaml's spec-decoding adjustments (or otherwise ensure every spec-decoding value declared in nvidia-master.yaml has a matching CI-priority entry).
Extended reasoning...
utils/ci_priority.py calculate_priority() reads entry.get('spec-decoding','') and looks it up in policy['adjustments']['spec-decoding'] (configs/ci-priority.yaml lines 19-22: only mtp, eagle, eagle3 defined) via a plain dict .get(..., 0) fallback -- no validation/error for unknown values. Before this diff, these three search-space entries (tp:8 kv-offloading:none; tp:8 hicache; tp:8 ep:8 dp-attn hicache) declared spec-decoding: mtp and received +0.75. After the rename to draft_model, the same lookup returns 0, silently subtracting 0.75 from a total score of roughly 3.5-4.25 (base 1.0 + agentic 1.0 + precision fp4 0.75 + model-prefix dsv4 0.75 [+ multi-node 1.25 if applicable] + spec-decoding). This is invoked from .github/workflows/run-sweep.yml, e2e-tests.yml, profile.yml and speedbench-al.yml, so every CI run that schedules this recipe's jobs now ranks them lower relative to siblings still labeled mtp, with no warning that the policy file was not updated alongside the recipe rename.
Verification: nit. The mechanism is real and reachable, but its only consequence is CI queue-ordering, not a functional break. configs/nvidia-master.yaml:943-945 changes three agentic-coding search-space arms from
spec-decoding: mtptospec-decoding: draft_model. configs/ci-priority.yaml:19-22 defines spec-decoding adjustments only formtp: 0.75,eagle: 0.75,eagle3: 0.75—draft_modelis not…