[AMD] dsv4-fp4-mi355x-sglang: switch fixed-seq-len search space to TP4#1768
[AMD] dsv4-fp4-mi355x-sglang: switch fixed-seq-len search space to TP4#1768seungrokj wants to merge 9 commits into
Conversation
…ter yaml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…able isl=1024 and expand isl=8192 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… space update Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
functionstackx
left a comment
There was a problem hiding this comment.
@seungrokj can u try looking into sgl mtp too? would switching it help? +viz @1am9trash
…dp-attn conc=512 point Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 50b4a94. Configure here.
…oint for dsv4-fp4-mi355x-sglang Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…n and TP4 TP-only rows for isl=1024 and isl=8192 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27528680882 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27528759942 |
1 similar comment
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27528759942 |
|
@functionstackx @cquil11 can you plz approve this ? |

Summary
dsv4-fp4-mi355x-sglangfixed-seq-len search space from TP8 to TP4 for bothisl=1024andisl=8192scenariosisl=8192coverage: add TP4 dp-attn sweep (conc 32–2048) alongside TP4 TP-only sweep (conc 1–32)perf-changelog.yamlwith change descriptionTest plan
dsv4-fp4-mi355x-sglangfixed-seq-len CI jobs launch with TP4 configs🤖 Generated with Claude Code
Note
Low Risk
YAML-only benchmark sweep tuning; no application or serving code paths change.
Overview
Updates
dsv4-fp4-mi355x-sglangfixed-seq-len benchmark sweeps on MI355X: the former TP8, dp-attn off latency rows (conc 1–32) are replaced with TP4 coverage—dp-attn on (conc 16–128) and dp-attn off (conc 1–32)—for both isl=1024 and isl=8192. The existing TP8 + dp-attn high-concurrency rows (conc 64–2048) are unchanged.Documents the change in
perf-changelog.yamlfor config keydsv4-fp4-mi355x-sglang.Reviewed by Cursor Bugbot for commit 64213b9. Bugbot is set up for automated code reviews on this repo. Configure here.