Skip to content

Require a code owner review - #8

Merged
JordanNanos merged 1 commit into
masterfrom
codex/add-codeowners
Aug 28, 2026
Merged

Require a code owner review#8
JordanNanos merged 1 commit into
masterfrom
codex/add-codeowners

Conversation

@JordanNanos

@JordanNanos JordanNanos commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Purpose

The repository needs named owners for all files. Branch protection requires one owner approval.

What changed

  • Add one repository-wide rule to .github/CODEOWNERS.
  • Assign @JordanNanos, @samharshe, and @Prathmesh234 as owners.
  • Require one code owner approval.
  • Remove the last-pusher approval rule.

Effect

  • Users: None.
  • Operators: One listed owner must approve each pull request.
  • Developers: GitHub requests reviews from the three listed owners.
  • Data and compatibility: None.

Technical terms

  • CODEOWNERS: A GitHub file that assigns reviewers to repository paths.
  • code owner: A person who reviews changes to assigned files.
  • branch protection: GitHub rules that control changes to master.

Validation

  • git diff --cached --check: Pass.
  • gh api repos/SemiAnalysisAI/ClusterMAX/collaborators/<login>/permission: Pass. Each owner has write or administrator access.
  • gh api repos/SemiAnalysisAI/ClusterMAX/branches/master/protection/required_pull_request_reviews: Pass. Code owner review is required.
  • Not run: Runtime tests do not apply to a reviewer assignment file.

Merge plan

  • Merge order: None. This PR can merge independently.
  • Dependency: Branch protection on master.
  • Release step: Merge this PR to activate the owner assignments.

Design decisions for approval

  • Approval required: No.
  • Decision: Require one approval from the three named owners.
  • Options: Assign users directly or assign an organization team.
  • Recommendation: Assign the three users directly as requested.
  • Approver: Jordan Nanos.

Risk and recovery

  • Risk: An unavailable owner can delay a pull request.
  • Safeguard: Any one of the three owners can approve.
  • Rollback: Remove the rule and disable required code owner reviews.

Excluded work

  • Path-specific ownership rules.
  • Organization team ownership.

Note

Low Risk
Process-only change (reviewer assignment); no application code, data, or runtime behavior.

Overview
Adds .github/CODEOWNERS with a single wildcard (*) rule so every path in the repo is owned by @JordanNanos, @samharshe, and @Prathmesh234.

When branch protection requires code owner reviews, GitHub will route PRs to those three accounts and one of them must approve before merge.

Reviewed by Cursor Bugbot for commit 7953d67. Bugbot is set up for automated code reviews on this repo. Configure here.

@JordanNanos
JordanNanos marked this pull request as ready for review August 28, 2026 02:04
@JordanNanos
JordanNanos merged commit 71de350 into master Aug 28, 2026
5 checks passed
@JordanNanos
JordanNanos deleted the codex/add-codeowners branch August 28, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant