Require a code owner review - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The repository needs named owners for all files. Branch protection requires one owner approval.
What changed
.github/CODEOWNERS.@JordanNanos,@samharshe, and@Prathmesh234as owners.Effect
Technical terms
CODEOWNERS: A GitHub file that assigns reviewers to repository paths.code owner: A person who reviews changes to assigned files.branch protection: GitHub rules that control changes tomaster.Validation
git diff --cached --check: Pass.gh api repos/SemiAnalysisAI/ClusterMAX/collaborators/<login>/permission: Pass. Each owner has write or administrator access.gh api repos/SemiAnalysisAI/ClusterMAX/branches/master/protection/required_pull_request_reviews: Pass. Code owner review is required.Merge plan
master.Design decisions for approval
Risk and recovery
Excluded work
Note
Low Risk
Process-only change (reviewer assignment); no application code, data, or runtime behavior.
Overview
Adds
.github/CODEOWNERSwith a single wildcard (*) rule so every path in the repo is owned by@JordanNanos,@samharshe, and@Prathmesh234.When branch protection requires code owner reviews, GitHub will route PRs to those three accounts and one of them must approve before merge.
Reviewed by Cursor Bugbot for commit 7953d67. Bugbot is set up for automated code reviews on this repo. Configure here.