Strip READ_PHONE_STATE from merged manifest#35
Merged
Conversation
A transitive dependency (likely ML Kit face detection / Play Services Basement in the full flavor) was injecting READ_PHONE_STATE into the merged manifest. The app doesn't need it, so remove it via the same tools:node="remove" pattern already used for INTERNET and ACCESS_NETWORK_STATE.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.google.mlkit:face-detectionin thefullflavor, which pulls Play Services Basement) was injectingandroid.permission.READ_PHONE_STATEinto the merged manifest.tools:node="remove", matching the existing pattern already in place forINTERNETandACCESS_NETWORK_STATE.Notes
main,oss,full) never declared this permission; only manifest merging from a dependency was adding it.app/build/outputs/apk/full/debug/withaapt dump permissions— or inspectapp/build/intermediates/merged_manifests/fullDebug/AndroidManifest.xml.Test plan
./gradlew assembleFullDebugsucceedsaapt dump permissions app/build/outputs/apk/full/debug/app-full-debug.apkno longer listsREAD_PHONE_STATEassembleOssDebug(should already be clean, but verify nothing regressed)Generated by Claude Code