Repository navigation
fix: replace game choices with searchable autocomplete - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the 26th game caused
/launchserverand/hangout_createto exceed Discord's 25-choice limit, preventing command synchronization and crashing the bot during startup. Both commands now use shared searchable autocomplete, returning at most 25 matching suggestions from the full catalog.Users can select a suggestion or submit a complete game name (case-insensitive) or valid ID. Unknown games are rejected before launching servers or creating hangout resources. Server watch messages now show the resolved game name. Biobuzz's simulator ID is corrected from
23to24, avoiding its collision with Override.Adds behavior tests for search, name/ID resolution, invalid-input rejection, and game selection in both commands, plus
make testand general testing instructions in the README.Validation
make test PYTHON=/private/tmp/xrc-autocomplete-check/bin/python).git diff --checkpassed.