Skip to content

[codex] fix FAK order type serialization#23

Merged
SebastianBoehler merged 2 commits into
mainfrom
codex/fix-fak-order-type
Jun 21, 2026
Merged

[codex] fix FAK order type serialization#23
SebastianBoehler merged 2 commits into
mainfrom
codex/fix-fak-order-type

Conversation

@SebastianBoehler

Copy link
Copy Markdown
Owner

Summary

  • Serialize OrderType::FAK as FAK instead of the unsupported IOC wire value.
  • Clarify the public enum comment and add a regression test for order-type serialization.
  • Bump the package version to 1.3.0 and update README release references.

Validation

  • cmake -S . -B /tmp/polymarket-issue22-localdeps-build ... && cmake --build /tmp/polymarket-issue22-localdeps-build --target test_order_type_serialization test_order_execution -j 8
  • ctest --test-dir /tmp/polymarket-issue22-localdeps-build --output-on-failure -E test_oracle_watcher_historical

Full ctest was also attempted. The only failure was test_oracle_watcher_historical, which hit HTTP 403 from https://polygon-bor.publicnode.com.

@SebastianBoehler SebastianBoehler merged commit 375f585 into main Jun 21, 2026
8 checks passed
@SebastianBoehler SebastianBoehler deleted the codex/fix-fak-order-type branch June 22, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant