Skip to content

fix(store-runtime): guard retained memory by served store identity #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 6 commits into from
Sep 10, 2026
Merged

fix(store-runtime): guard retained memory by served store identity #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
10206a2
test(store-runtime): prove retained memory denies store identity drift
ScriptedAlchemy Sep 9, 2026
173163d
fix(store-runtime): guard retained memory by served store identity
ScriptedAlchemy Sep 9, 2026
300c967
fix(store-runtime): honor read access with read-only leases
ScriptedAlchemy Sep 9, 2026
cb224b6
refactor(daemon): drop retained owner facade
ScriptedAlchemy Sep 9, 2026
26e8c33
fix(daemon): resolve retained memory identity per call
ScriptedAlchemy Sep 10, 2026
8b5c535
Merge remote-tracking branch 'origin/codex/tracedecay-total-redesign-…
ScriptedAlchemy Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 61 additions & 44 deletions crates/tracedecay-store-runtime/src/retained_memory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,21 @@ impl<'a> DirectRetainedMemoryPortV1<'a> {
request: Read<'_>,
) -> Result<ApplicationOutcome<RetainedSurfaceResultV1>, RetainedSurfaceExecutionErrorV1> {
let (memory_scope, selector) = request.scope();
let access = match request {
Read::Search(_) => MemoryTargetAccessV1::RecordRetrieval,
Read::Probe(_)
| Read::Related(_)
| Read::Reason(_)
| Read::Contradict(_)
| Read::Get(_)
| Read::List(_) => MemoryTargetAccessV1::Read,
};
execute_scoped_memory!(
self,
context,
memory_scope,
selector,
MemoryTargetAccessV1::Read,
access,
execute_read_on_db(request)
)
}
Expand Down Expand Up @@ -278,55 +287,63 @@ impl<'a> DirectRetainedMemoryPortV1<'a> {
}
}

impl DirectRetainedMemoryPortV1<'_> {
pub async fn execute_request(
&self,
context: RetainedSurfaceExecutionContextV1<'_>,
request: RetainedMemoryRequestV1<'_>,
) -> Result<ApplicationOutcome<RetainedSurfaceResultV1>, RetainedSurfaceExecutionErrorV1> {
match request {
RetainedMemoryRequestV1::FactStoreAdd(request) => {
self.execute_add(&context, request).await
}
RetainedMemoryRequestV1::FactStoreSearch(request) => {
self.execute_read(&context, Read::Search(request)).await
}
RetainedMemoryRequestV1::FactStoreProbe(request) => {
self.execute_read(&context, Read::Probe(request)).await
}
RetainedMemoryRequestV1::FactStoreRelated(request) => {
self.execute_read(&context, Read::Related(request)).await
}
RetainedMemoryRequestV1::FactStoreReason(request) => {
self.execute_read(&context, Read::Reason(request)).await
}
RetainedMemoryRequestV1::FactStoreContradict(request) => {
self.execute_read(&context, Read::Contradict(request)).await
}
RetainedMemoryRequestV1::FactStoreGet(request) => {
self.execute_read(&context, Read::Get(request)).await
}
RetainedMemoryRequestV1::FactStoreUpdate(request) => {
self.execute_update(&context, request).await
}
RetainedMemoryRequestV1::FactStoreRemove(request) => {
self.execute_remove(&context, request).await
}
RetainedMemoryRequestV1::FactStoreSupersede(request) => {
self.execute_supersede(&context, request).await
}
RetainedMemoryRequestV1::FactStoreList(request) => {
self.execute_read(&context, Read::List(request)).await
}
RetainedMemoryRequestV1::FactFeedback(request) => {
self.execute_feedback(&context, request).await
}
RetainedMemoryRequestV1::MemoryStatus(request) => {
self.execute_status(&context, request).await
}
}
}
}

impl RetainedMemoryExecutionPortV1 for DirectRetainedMemoryPortV1<'_> {
fn execute_memory<'a>(
&'a self,
context: RetainedSurfaceExecutionContextV1<'a>,
request: RetainedMemoryRequestV1<'a>,
) -> RetainedSurfaceExecutionFutureV1<'a> {
Box::pin(async move {
match request {
RetainedMemoryRequestV1::FactStoreAdd(request) => {
self.execute_add(&context, request).await
}
RetainedMemoryRequestV1::FactStoreSearch(request) => {
self.execute_read(&context, Read::Search(request)).await
}
RetainedMemoryRequestV1::FactStoreProbe(request) => {
self.execute_read(&context, Read::Probe(request)).await
}
RetainedMemoryRequestV1::FactStoreRelated(request) => {
self.execute_read(&context, Read::Related(request)).await
}
RetainedMemoryRequestV1::FactStoreReason(request) => {
self.execute_read(&context, Read::Reason(request)).await
}
RetainedMemoryRequestV1::FactStoreContradict(request) => {
self.execute_read(&context, Read::Contradict(request)).await
}
RetainedMemoryRequestV1::FactStoreGet(request) => {
self.execute_read(&context, Read::Get(request)).await
}
RetainedMemoryRequestV1::FactStoreUpdate(request) => {
self.execute_update(&context, request).await
}
RetainedMemoryRequestV1::FactStoreRemove(request) => {
self.execute_remove(&context, request).await
}
RetainedMemoryRequestV1::FactStoreSupersede(request) => {
self.execute_supersede(&context, request).await
}
RetainedMemoryRequestV1::FactStoreList(request) => {
self.execute_read(&context, Read::List(request)).await
}
RetainedMemoryRequestV1::FactFeedback(request) => {
self.execute_feedback(&context, request).await
}
RetainedMemoryRequestV1::MemoryStatus(request) => {
self.execute_status(&context, request).await
}
}
})
Box::pin(async move { self.execute_request(context, request).await })
}
}

Expand Down
Loading
Loading