refactor(lifecycle): move replay, PR git kernels, and query wait to owners - #1180
Merged
ScriptedAlchemy merged 15 commits intoSep 9, 2026
Conversation
Move admitted graph-query adapters, branch diagnostics, store-meta counters, and fact-owner identity into their owner crates so TraceDecay keeps handles and typed results instead of façade logic.
Move DashboardGraphTestRuntimeV1 out of the production dashboard module into a test-transport-only fixture so #1088 test runtimes do not ship in composition code.
The generation wait/retry kernel belongs with the scheduler owner; root keeps only the spawn onto the admitted project.
Activation still mounts the scheduler in the daemon; Git identity, leases, and teardown proofs now live with pr_tracking.
…plan-reopened' into grok/w2-facade-contraction
…plan-reopened' into grok/w2-branch-lifecycle # Conflicts: # Cargo.lock # crates/tracedecay/src/daemon/pr_autotrack.rs
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4efc97499
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (key, value) in fields { | ||
| let _ = write!(extras, " {key}={value}"); | ||
| } | ||
| tracing::info!("{event}{extras}"); |
There was a problem hiding this comment.
When the daemon runs without an explicit RUST_LOG, the CLI installs a WARN-level tracing subscriber, so routing the former unconditional log_daemon_event calls through this tracing::info! helper suppresses non-retryable bootstrap and replay-stop reason codes. In particular, ReplayPassDecision::Stop terminates the asynchronous worker without returning a typed error, and wait_idle can subsequently report success, leaving no default-visible indication of the failure; emit the failure receipts at an appropriate default-visible tracing level.
AGENTS.md reference: AGENTS.md:L108-L112
Useful? React with 👍 / 👎.
…cade-claim-clarity # Conflicts: # crates/tracedecay/src/dashboard.rs
refactor(root): contract the TraceDecay facade onto owner crates
…80-lifecycle-correction
ScriptedAlchemy
merged commit Sep 9, 2026
7781ee7
into
codex/tracedecay-total-redesign-plan-reopened
Contributor
Performance Comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move remaining worktree adapters, profile replay, and deferred query waiting into their existing owner crates. Preserve the root-installed Hermes admission callback, exact branch/source boundaries, and existing cancellation behavior.
The corrected head keeps terminal replay failures visible under the default WARN filter and keeps three internal Git helpers private. Actual root bootstrap/WARN and Hermes durable admission/receipt regressions pass (cc-12963/12964, two tests). Strict owner-crate Clippy passes with zero warnings/errors (cc-12966); independent review is clear.