Skip to content

refactor(sessions): extract retained owners from the root crate - #1179

Merged
ScriptedAlchemy merged 9 commits into
codex/tracedecay-total-redesign-plan-reopenedfrom
grok/w2-retained-owners
Sep 9, 2026
Merged

refactor(sessions): extract retained owners from the root crate#1179
ScriptedAlchemy merged 9 commits into
codex/tracedecay-total-redesign-plan-reopenedfrom
grok/w2-retained-owners

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Moves retained session/LCM execution into session runtime and retained memory execution into store runtime, leaving the root crate responsible for assembling the selected authorities. Removes the redundant direct profile/session forwarding wrappers.

Profile session storage is acquired lazily inside admitted, bounded execution. A broken session store therefore does not disable unrelated memory requests; expired or cancelled requests do not acquire session storage. Exact registered project/store identity and the canonical enrollment helper are preserved.

Integrates the current #707 maintenance and replay owners, including the canonical store-runtime shutdown receipt and dependency direction.

Validation: 18 retained-runtime tests, six root retained-owner journeys, and strict Clippy passed for the corrected extraction. After merging #707 at 0b5ccfd, the six root journeys pass again; the focused real broken-session/healthy-memory regression also passes (one test). Formatting and diff checks pass. No claim of full platform or native-semantic qualification.

Part of #707; addresses the retained-owner portion of #1073 and #1088.

@changeset-bot

changeset-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 43ef7ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-09T18:42:29.611795Z 04cb5f3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit 5485bc7 into codex/tracedecay-total-redesign-plan-reopened Sep 9, 2026
12 of 13 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Performance Comparison codex/tracedecay-total-redesign-plan-reopenedgrok/w2-retained-owners

Total Elapsed Time: 3.93s → 3.91s (-0.5%)
CPU Baseline: 90.44µs → 91.56µs (+1.2%)
Benchmark ID: index-bench-timing

timing - Execution duration of functions.

+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| Function                                 | Calls                      | Avg                            | P95                            | Total                          | % Total                      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| tracedecay-index-bench                   | 1 → 1 (+0.0%)              | 3.93s → 3.91s (-0.5%)          | 3.93s → 3.92s (-0.3%)          | 3.93s → 3.91s (-0.5%)          | 100.00% → 100.00% (+0.0%)    |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.append_pages              | 13 → 13 (+0.0%)            | 119.75ms → 119.04ms (-0.6%)    | 164.23ms → 162.66ms (-1.0%)    | 1.56s → 1.55s (-0.6%)          | 39.58% → 39.54% (-0.1%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.workers.install               | 83 → 83 (+0.0%)            | 13.38ms → 13.25ms (-1.0%)      | 46.30ms → 46.10ms (-0.4%)      | 1.11s → 1.10s (-0.9%)          | 28.24% → 28.10% (-0.5%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| domain.canonical.sha256                  | 110414 → 110414 (+0.0%)    | 8.69µs → 8.74µs (+0.6%)        | 11.36µs → 11.42µs (+0.5%)      | 959.65ms → 965.59ms (+0.6%)    | 24.40% → 24.67% (+1.1%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.build.and_publish             | 2 → 2 (+0.0%)              | 444.14ms → 447.27ms (+0.7%)    | 505.94ms → 511.44ms (+1.1%)    | 888.27ms → 894.53ms (+0.7%)    | 22.58% → 22.86% (+1.2%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.batch.sqlite              | 13 → 13 (+0.0%)            | 68.06ms → 68.01ms (-0.1%)      | 92.93ms → 92.27ms (-0.7%)      | 884.80ms → 884.08ms (-0.1%)    | 22.50% → 22.59% (+0.4%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.batch.postings            | 13 → 13 (+0.0%)            | 59.90ms → 59.80ms (-0.2%)      | 83.69ms → 82.25ms (-1.7%)      | 778.67ms → 777.35ms (-0.2%)    | 19.80% → 19.86% (+0.3%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.finalization.advance_wake | 14 → 14 (+0.0%)            | 43.95ms → 43.22ms (-1.7%)      | 274.73ms → 268.30ms (-2.3%)    | 615.31ms → 605.04ms (-1.7%)    | 15.64% → 15.46% (-1.2%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.chunk.index_file              | 276 → 276 (+0.0%)          | 2.17ms → 2.11ms (-2.8%)        | 3.02ms → 2.95ms (-2.3%)        | 599.21ms → 582.49ms (-2.8%)    | 15.23% → 14.88% (-2.3%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.prepare_pages             | 13 → 13 (+0.0%)            | 42.79ms → 42.09ms (-1.6%)      | 60.65ms → 60.56ms (-0.1%)      | 556.32ms → 547.12ms (-1.7%)    | 14.14% → 13.98% (-1.1%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.extract.parser_artifact       | 276 → 276 (+0.0%)          | 1.86ms → 1.89ms (+1.6%)        | 2.89ms → 2.89ms (+0.0%)        | 514.33ms → 522.45ms (+1.6%)    | 13.08% → 13.35% (+2.1%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.batch.postings.ngram_rows | 13 → 13 (+0.0%)            | 33.11ms → 33.25ms (+0.4%)      | 45.15ms → 45.61ms (+1.0%)      | 430.45ms → 432.30ms (+0.4%)    | 10.94% → 11.05% (+1.0%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.batch.parallel_prepare    | 13 → 13 (+0.0%)            | 33.45ms → 32.87ms (-1.7%)      | 47.42ms → 47.42ms (+0.0%)      | 434.85ms → 427.33ms (-1.7%)    | 11.06% → 10.92% (-1.3%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.build.assemble                | 2 → 2 (+0.0%)              | 206.37ms → 208.39ms (+1.0%)    | 215.22ms → 218.76ms (+1.6%)    | 412.75ms → 416.77ms (+1.0%)    | 10.49% → 10.65% (+1.5%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.chunk.build                   | 276 → 276 (+0.0%)          | 1.27ms → 1.28ms (+0.8%)        | 1.83ms → 1.81ms (-1.1%)        | 351.35ms → 352.47ms (+0.3%)    | 8.93% → 9.01% (+0.9%)        |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+

Generated with hotpath-rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant