refactor(daemon-service): move query authz and remote protocol - #1178
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3af84fb4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub fn new( | ||
| access: impl Fn(UtcMicros) -> CurrentCallableCodeAccessFuture<'static> + Send + Sync + 'static, | ||
| ) -> Self { |
There was a problem hiding this comment.
Keep this constructor private: because DaemonCallableCodeAuthorizationSource is publicly reexported, pub fn new lets any consumer present an arbitrary closure as the daemon's canonical source-access authority instead of using the configuration-backed production path. A repository-wide search at this commit finds its only caller in this module's #[cfg(test)] fixture, so this widens the production authorization boundary solely for tests and permits shadow authorities.
AGENTS.md reference: AGENTS.md:L121-L123
Useful? React with 👍 / 👎.
| pub fn remote_query_result_observation( | ||
| operation_ref: &str, | ||
| expected_shards: usize, | ||
| result: &tracedecay_contracts::remote::query::RemoteQueryResultV1, |
There was a problem hiding this comment.
Do not expose this as an unconditional production API: the only repository callers are the two cases in crates/tracedecay/src/daemon/remote_protocol_tests.rs, while the actual runtime path calls the private observability implementation directly. Moving the old #[cfg(test)] pub(super) wrapper across the crate boundary as plain pub leaves a test-only surface compiled and callable in every shipped daemon-service build; expose it under the existing test-helpers feature instead.
AGENTS.md reference: AGENTS.md:L121-L123
Useful? React with 👍 / 👎.
01b8635
into
codex/tracedecay-total-redesign-plan-reopened
Performance Comparison
|
1 participant
Move daemon query authorization and remote protocol composition into daemon-service while retaining the canonical receiving-only frame-transfer authority in store-runtime. The merged result removes the obsolete local transfer implementation and exposes the existing query observation function directly.
Independently reviewed against the integrated #707 owner changes. Corrected-head protocol recovery test passes (cc-12945, 1 test); strict daemon-service library/test Clippy passes with zero warnings or errors (cc-12946). Root integration checks follow on the combined tip.