Skip to content

refactor(maintenance): extract store kernels and tick policy from root - #1177

Merged
ScriptedAlchemy merged 10 commits into
codex/tracedecay-total-redesign-plan-reopenedfrom
grok/w2-maintenance-kernels
Sep 9, 2026
Merged

refactor(maintenance): extract store kernels and tick policy from root#1177
ScriptedAlchemy merged 10 commits into
codex/tracedecay-total-redesign-plan-reopenedfrom
grok/w2-maintenance-kernels

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Move maintenance kernels into their owning crates while keeping one canonical enrollment identity implementation. Retention, lifecycle, and selected-memory callers now use the same policy. Degraded maintenance outcomes retain warning-level visibility under the default log filter.

The corrected head preserves existing cancellation and durability behavior. Validation: two enrollment regressions, three selected-memory authorization/isolation journeys, and one real WARN/INFO subscriber test pass (cc-12932/12935/12933). Strict runtime-core, maintenance, and root library/test Clippy passes without warnings (cc-12934).

@changeset-bot

changeset-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c661c92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T18:37:24.715172Z f27db40 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f27db40b33

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/tracedecay-maintenance/src/lib.rs Outdated
@ScriptedAlchemy
ScriptedAlchemy merged commit 0b5ccfd into codex/tracedecay-total-redesign-plan-reopened Sep 9, 2026
13 checks passed
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Performance Comparison codex/tracedecay-total-redesign-plan-reopenedgrok/w2-maintenance-kernels

Total Elapsed Time: 3.95s → 4.27s (+8.1%)
CPU Baseline: 87.12µs → 81.42µs (-6.5%)
Benchmark ID: index-bench-timing

timing - Execution duration of functions.

+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| Function                                 | Calls                      | Avg                             | P95                             | Total                            | % Total                      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| tracedecay-index-bench                   | 1 → 1 (+0.0%)              | 3.95s → 4.27s (+8.1%)           | 3.95s → 4.27s (+8.1%)           | 3.95s → 4.27s (+8.1%)            | 100.00% → 100.00% (+0.0%)    |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.append_pages              | 13 → 13 (+0.0%)            | 120.98ms → 133.30ms (+10.2%)    | 160.83ms → 186.91ms (+16.2%)    | 1.57s → 1.73s (+10.2%)           | 39.84% → 40.60% (+1.9%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.workers.install               | 83 → 83 (+0.0%)            | 14.14ms → 15.55ms (+10.0%)      | 47.45ms → 59.08ms (+24.5%) ⚠️   | 1.17s → 1.29s (+10.3%)           | 29.74% → 30.23% (+1.6%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| domain.canonical.sha256                  | 110414 → 110414 (+0.0%)    | 9.34µs → 9.38µs (+0.4%)         | 12.62µs → 12.72µs (+0.8%)       | 1.03s → 1.04s (+1.0%)            | 26.13% → 24.28% (-7.1%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.build.and_publish             | 2 → 2 (+0.0%)              | 459.75ms → 474.71ms (+3.3%)     | 532.15ms → 547.88ms (+3.0%)     | 919.50ms → 949.42ms (+3.3%)      | 23.29% → 22.24% (-4.5%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.sqlite              | 13 → 13 (+0.0%)            | 69.30ms → 72.34ms (+4.4%)       | 91.42ms → 98.17ms (+7.4%)       | 900.86ms → 940.42ms (+4.4%)      | 22.82% → 22.03% (-3.5%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.postings            | 13 → 13 (+0.0%)            | 60.68ms → 63.18ms (+4.1%)       | 81.00ms → 85.85ms (+6.0%)       | 788.80ms → 821.36ms (+4.1%)      | 19.98% → 19.24% (-3.7%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.finalization.advance_wake | 14 → 14 (+0.0%)            | 43.57ms → 49.21ms (+12.9%)      | 271.84ms → 309.07ms (+13.7%)    | 609.93ms → 688.87ms (+12.9%)     | 15.45% → 16.14% (+4.5%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.prepare_pages             | 13 → 13 (+0.0%)            | 43.64ms → 51.34ms (+17.6%)      | 61.54ms → 78.84ms (+28.1%) ⚠️   | 567.34ms → 667.43ms (+17.6%)     | 14.37% → 15.64% (+8.8%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.chunk.index_file              | 276 → 276 (+0.0%)          | 2.22ms → 2.35ms (+5.9%)         | 3.20ms → 3.35ms (+4.7%)         | 611.55ms → 649.16ms (+6.1%)      | 15.49% → 15.21% (-1.8%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.extract.parser_artifact       | 276 → 276 (+0.0%)          | 2.05ms → 2.12ms (+3.4%)         | 3.09ms → 3.23ms (+4.5%)         | 565.89ms → 584.40ms (+3.3%)      | 14.34% → 13.69% (-4.5%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.parallel_prepare    | 13 → 13 (+0.0%)            | 34.65ms → 41.92ms (+21.0%) ⚠️   | 48.79ms → 65.60ms (+34.5%) ⚠️   | 450.42ms → 544.91ms (+21.0%) ⚠️  | 11.41% → 12.77% (+11.9%)     |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.postings.ngram_rows | 13 → 13 (+0.0%)            | 34.06ms → 35.23ms (+3.4%)       | 46.14ms → 48.43ms (+5.0%)       | 442.74ms → 458.04ms (+3.5%)      | 11.22% → 10.73% (-4.4%)      |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.build.assemble                | 2 → 2 (+0.0%)              | 204.58ms → 209.53ms (+2.4%)     | 212.99ms → 218.37ms (+2.5%)     | 409.16ms → 419.07ms (+2.4%)      | 10.37% → 9.82% (-5.3%)       |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.chunk.build                   | 276 → 276 (+0.0%)          | 1.39ms → 1.44ms (+3.6%)         | 1.99ms → 2.08ms (+4.5%)         | 384.63ms → 397.50ms (+3.3%)      | 9.74% → 9.31% (-4.4%)        |
+------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+

Generated with hotpath-rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant