refactor(tracedecay): keep bench and test runtimes off lib - #1176
Merged
ScriptedAlchemy merged 5 commits intoSep 9, 2026
Merged
Conversation
Default library builds no longer compile benchmark harnesses or HostAdmissionTestRuntimeV1. The shipped tracedecay bench command stays on a bench feature selected by the CLI production build.
…plan-reopened' into grok/w2-bench-surface
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 189cf9fb3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub mod host_admission; | ||
| pub mod test_support; | ||
| #[cfg(any(test, feature = "test-helpers"))] | ||
| pub use test_support::host_admission; |
There was a problem hiding this comment.
When test-helpers is enabled, this re-export leaves both tracedecay::test_support::host_admission and the legacy tracedecay::host_admission path public, and the repository's fixture callers still use the latter, so the move creates a temporary compatibility façade rather than completing the cutover. Migrate those callers in this change and remove the alias; repository guidance requires caller migrations and compatibility-façade deletion in one delivery slice.
AGENTS.md reference: AGENTS.md:L130-L137
Useful? React with 👍 / 👎.
ScriptedAlchemy
merged commit Sep 9, 2026
eb2c998
into
codex/tracedecay-total-redesign-plan-reopened
12 checks passed
This was referenced Sep 9, 2026
Contributor
Performance Comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocate benchmark and fixture sources, remove the host-admission compatibility alias, and update all callers. Query benchmarking is opt-in for library builds and selected by the production CLI; the other fixtures retain their existing feature gates.
Validated the corrected head against the integrated #707 floor with strict all-target Clippy for tracedecay and tracedecay-cli, including test-transport (cc-12921; zero errors or warnings).