refactor(runtime): simplify composition and verify ownership boundaries - #1173
Merged
ScriptedAlchemy merged 8 commits intoSep 9, 2026
Conversation
Resolve argument-count offenders through existing authorities: complete_tool_call reads connection identity and notifications from its server; search and context use McpToolContext index capabilities; application surface accepts RequestControls; affected-test rendering retains TestRunOutput on both success and failure. Keep item-scoped exceptions for AdminCliContext::with_project and handle_admin_cli (independent admitted stores, sync, protocol controls), handle_dashboard (independent optional mounted providers), handle_status (independent observability authorities), terminal_failure (exact admitted settlement and dispatched target evidence), and redundancy test_pair (independent fixture node dimensions). Each exception records its invariant at the function. No new argument bags or crate-wide allowances. Verification: affected-workflow tests passed 19 cases (cc-12618). Strict Clippy and graph/request checks are pending; source is checkpointed for combined integration verification.
Remove the crate-wide too_many_arguments allowance. Existing MCP owners replace repeated arguments; remaining composition and fixture boundaries keep item-scoped reasons rather than adding one-use parameter bags. Root inventory/disposition: LSP registration, code-index mount, project server composition, portable warmup/request/dispatch and registered branch opening retain distinct admitted owners. Maintenance run/tick retain store and continuation lifetimes. Scheduler loop, user-job pass, retained settlement, effect admission and reused-skip abandonment retain cancellation, configuration and settlement guards. Retained LCM query mapping preserves independent filters. Host-session, detached-session and semantic-activation fixtures intentionally vary authority dimensions independently. MCP inventory/dispositions are recorded in the preceding handler commit; combined effect preparation retains its explicit authority-binding exception. Validation: integrated root all-target Clippy with test-helpers and -D warnings passes (cc-12676). All 52 affected MCP tests pass.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ScriptedAlchemy
merged commit Sep 9, 2026
11509a6
into
codex/tracedecay-total-redesign-plan-reopened
15 checks passed
Contributor
Performance Comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composition root now reuses admitted MCP owners instead of passing their fields separately, and enables
too_many_argumentswith reasoned item-level exceptions at actual composition boundaries. Remote HTTP routes mount canonical operation ports directly, removing the forwarding owner while retaining transport admission and cancellation behavior.This follow-up also preserves the original HTTPS measurement middleware order and adds a regression using a real contended SQLite writer during semantic bootstrap and shutdown. Integration Clippy findings are fixed at their declarations.
Validation: 52 MCP tests, 9 API tests plus 1 contract test, 33 mounted HTTP/TLS tests, and real writer-contention tests passed (including a 25% CPU quota run). Both Hotpath root test-compilation gates and workspace Hotpath Clippy passed on the transport candidate. Final combined root all-target Clippy with
test-helperspassed with zero errors and warnings (cc-12740, commitdce72a7a1).Partial progress on #1086, #1088, #1073 and #913; these remain open for their remaining acceptance criteria. Targets the head branch of draft #707, not master.