fix(runtime-core): keep anchor upgrade off caller future frames - #1128
Merged
ScriptedAlchemy merged 2 commits intoSep 9, 2026
Merged
Conversation
`cargo build -p tracedecay-cli --all-features --bin tracedecay --locked` overflowed the trait solver with E0275 (`&str: Send`) while checking the daemon project-open future. Auto-trait obligations walk every future a caller inlines, and the deepest leaf on that path was the array literal in `validate_alias_copy_conflicts`: iterating it in place holds a `std::array::IntoIter<&str, 2>` across the query `await`, whose `MaybeDangling`/`ManuallyDrop`/`MaybeUninit`/`PolymorphicIter` layers are re-entered for every obligation raised above it. Borrowing a promoted slice leaves a plain `slice::Iter` on that frame instead. Async lowering also expands an awaited future into its caller, so the two anchor upgrade phases expanded into every migration, admission, and store-open future that installs this schema; they are now awaited through a box, as the project-open phases already are. The install future is 2,144 B under `--features hotpath`, down from 7,664 B, and the size probe fails if either phase is inlined again.
…plan-reopened' into sol/alias-validation-depth
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ScriptedAlchemy
merged commit Sep 9, 2026
3fd7643
into
codex/tracedecay-total-redesign-plan-reopened
9 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
validate_alias_copy_conflictsheld an arrayIntoIter<&str, 2>across an await at the deepest store-open migration chain, consuming repeated auto-trait solver/layout depth. The alias/disposition upgrade futures were also inlined into every caller.Fix
Evidence
No timeout, feature, or recursion-limit change.