Skip to content

refactor(session-temporal): call candidate read directly - #1123

Merged
ScriptedAlchemy merged 3 commits into
codex/tracedecay-total-redesign-plan-reopenedfrom
sol/temporal-candidate-port-1088
Sep 9, 2026
Merged

refactor(session-temporal): call candidate read directly#1123
ScriptedAlchemy merged 3 commits into
codex/tracedecay-total-redesign-plan-reopenedfrom
sol/temporal-candidate-port-1088

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • delete private GlobalDbPreparedCandidatePort
  • have the temporal store prepare root candidate cohorts by paging directly through produce_candidates_from_request
  • reuse canonical bounded pull helpers without a replacement wrapper
  • preserve budgets, pagination, cancellation, hydration and typed store failures

Tests

  • session-temporal-store: 151 passed
  • added manual-loop equivalence, budget-exceeded and cancellation tests
  • affected check/clippy and formatting passed

Part of #1088.

Delete GlobalDbPreparedCandidatePort and prepare root-wide candidate
cohorts by calling produce_candidates_from_request from temporal
execution. Export shared prepared-candidate pull helpers and add
equivalence, budget, and cancellation tests.

Refs #1088.
…/temporal-candidate-port-1088

Integrate latest #707 trigger-repair fix before candidate-port cutover.
…plan-reopened' into sol/temporal-candidate-port-1088
@changeset-bot

changeset-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2eea228

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T01:47:52.323137Z 2eea228 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit 0b04bce into codex/tracedecay-total-redesign-plan-reopened Sep 9, 2026
6 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant