Add warning for session defaults - #27
Merged
sahilsunny merged 1 commit intoJul 9, 2026
Merged
Conversation
Session defaults persists until manually removed from the session. So when using commands that are not compatible with the params, the system simply ignores the params. Instead of it, this fix adds a warning that the param was skipped due to non-compatibility. So it will apply when running valid commands and warn when running invalid commands but it just continues to execute after the warning.
wfn
approved these changes
Jul 9, 2026
kostas-jakeliunas-sb
approved these changes
Jul 9, 2026
kostas-jakeliunas-sb
added a commit
that referenced
this pull request
Jul 13, 2026
test_session_default_skip_warning_on_screen asserted against the visible pyte screen, but the warning is a single line printed before the full `google --help` output, which immediately scrolls it out of the 32-row viewport. The test only passed when the pump captured an intermediate frame before the scroll — a race that failed on random OS/Python matrix cells (seen on main pushes for #27/#28 and on SCR-560 CI runs). Match on the accumulated ANSI-stripped raw PTY stream instead, which is scroll-immune: add _strip_ansi/_pump_until_raw and use them in both session-default tests (the negative test asserts on everything ever printed, which is also a stronger check than the final screen). Also makes the positive test return immediately instead of waiting out the 20s pump timeout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sahilsunny
added a commit
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session defaults persists until manually removed from the session. So when using commands that are not compatible with the params, the system simply ignores the params. Instead of it, this fix adds a warning that the param was skipped due to non-compatibility. So it will apply when running valid commands and warn when running invalid commands but it just continues to execute after the warning.