Skip to content

theia-ide: Add version 1.74.100 & context menu for folders - #18366

Open
delassio wants to merge 8 commits into
ScoopInstaller:masterfrom
delassio:master
Open

theia-ide: Add version 1.74.100 & context menu for folders#18366
delassio wants to merge 8 commits into
ScoopInstaller:masterfrom
delassio:master

Conversation

@delassio

Copy link
Copy Markdown
Contributor

Added 'Open with Theia IDE' context menu entry for folders

  • [ X ] Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • [ X ] I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 091c467e-bca8-4454-97ae-443520b21c03

📥 Commits

Reviewing files that changed from the base of the PR and between e303f70 and 761e476.

📒 Files selected for processing (1)
  • bucket/theia-ide.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/theia-ide.json

Included review availability: Your plan includes up to 8 reviews per rolling hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

Adds Theia IDE registry scripts for directory and directory-background context-menu entries. The manifest processes registry templates during installation, optionally rewrites registry roots, imports the installation script, and conditionally imports the uninstall script. The manifest notes now contain multiple entries.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 761e4

This localized change adds folder context-menu support, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the added folder context-menu feature.
Description check ✅ Passed The description states the change and includes both required checklist items, but it does not provide a related issue reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
bucket/theia-ide.json (1)

17-40: 🩺 Stability & Availability | 🔵 Trivial

Test both registry lifecycle paths before merging.

scoop config debug true
# Optional: scoop config gh_token <read-only-token>
.\bin\checkver.ps1 -App theia-ide -f
.\bin\formatjson.ps1 -App theia-ide

scoop install .\bucket\theia-ide.json -a 64bit
reg query "HKCU\Software\Classes\Directory\shell\Open with &Theia IDE"
reg query "HKCU\Software\Classes\Directory\Background\shell\Open with &Theia IDE"
scoop uninstall theia-ide

# Also validate the global HKLM rewrite:
scoop install -g .\bucket\theia-ide.json -a 64bit
reg query "HKLM\Software\Classes\Directory\shell\Open with &Theia IDE"
scoop uninstall -g theia-ide
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/theia-ide.json` around lines 17 - 40, Validate the theia-ide
post_install and uninstaller registry lifecycle for both per-user and global
installs. Confirm HKCU context-menu entries are created and removed for a normal
install, then confirm the $global rewrite creates the corresponding HKLM entries
and removes them during global uninstall. Run the repository’s checkver and
format validation before merging, and correct any lifecycle failures found.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/theia-ide.json`:
- Around line 17-40: Update the post_install and uninstaller scripts to fail
explicitly when registry integration cannot complete: require the expected
scripts/theia-ide registry templates and install-context.reg before copying or
importing, and validate the native reg import result for both install and
uninstall, propagating failure instead of allowing Scoop to report success.
- Line 8: Update the removal note in the manifest entry to tell users that Scoop
automatically removes the context-menu entry during uninstall, instead of
displaying the non-pasteable `$dir` registry command; leave the existing
uninstall behavior unchanged.

---

Nitpick comments:
In `@bucket/theia-ide.json`:
- Around line 17-40: Validate the theia-ide post_install and uninstaller
registry lifecycle for both per-user and global installs. Confirm HKCU
context-menu entries are created and removed for a normal install, then confirm
the $global rewrite creates the corresponding HKLM entries and removes them
during global uninstall. Run the repository’s checkver and format validation
before merging, and correct any lifecycle failures found.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 840ba4cf-6b0c-4c75-b0e7-4768d026af35

📥 Commits

Reviewing files that changed from the base of the PR and between 3cface8 and b7e893b.

📒 Files selected for processing (3)
  • bucket/theia-ide.json
  • scripts/theia-ide/install-context.reg
  • scripts/theia-ide/uninstall-context.reg

Comment thread bucket/theia-ide.json Outdated
Comment thread bucket/theia-ide.json
@delassio

delassio commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

please merge this as there is no conflict

@delassio

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

theia-ide

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@delassio

delassio commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

All changes work as expected when tested locally : post_install now fails explicitly (via throw) when the registry template source directory, install-context.reg, or a non-zero reg import exit code indicates a problem, instead of silently continuing. uninstaller now also checks the reg import exit code and throws on failure.

@delassio delassio closed this Aug 17, 2026
@delassio delassio changed the title theia-ide: add context menu for folders theia-ide: Add version 1.74.100 with context menu for folders Aug 17, 2026
@delassio delassio changed the title theia-ide: Add version 1.74.100 with context menu for folders theia-ide: Add version 1.74.100 & context menu for folders Aug 17, 2026
@delassio delassio reopened this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant