theia-ide: Add version 1.74.100 & context menu for folders - #18366
theia-ide: Add version 1.74.100 & context menu for folders#18366delassio wants to merge 8 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 6 remain after this review. 📝 WalkthroughWalkthroughAdds Theia IDE registry scripts for directory and directory-background context-menu entries. The manifest processes registry templates during installation, optionally rewrites registry roots, imports the installation script, and conditionally imports the uninstall script. The manifest notes now contain multiple entries. Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change adds folder context-menu support, and no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
bucket/theia-ide.json (1)
17-40: 🩺 Stability & Availability | 🔵 TrivialTest both registry lifecycle paths before merging.
scoop config debug true # Optional: scoop config gh_token <read-only-token> .\bin\checkver.ps1 -App theia-ide -f .\bin\formatjson.ps1 -App theia-ide scoop install .\bucket\theia-ide.json -a 64bit reg query "HKCU\Software\Classes\Directory\shell\Open with &Theia IDE" reg query "HKCU\Software\Classes\Directory\Background\shell\Open with &Theia IDE" scoop uninstall theia-ide # Also validate the global HKLM rewrite: scoop install -g .\bucket\theia-ide.json -a 64bit reg query "HKLM\Software\Classes\Directory\shell\Open with &Theia IDE" scoop uninstall -g theia-ide🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/theia-ide.json` around lines 17 - 40, Validate the theia-ide post_install and uninstaller registry lifecycle for both per-user and global installs. Confirm HKCU context-menu entries are created and removed for a normal install, then confirm the $global rewrite creates the corresponding HKLM entries and removes them during global uninstall. Run the repository’s checkver and format validation before merging, and correct any lifecycle failures found.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/theia-ide.json`:
- Around line 17-40: Update the post_install and uninstaller scripts to fail
explicitly when registry integration cannot complete: require the expected
scripts/theia-ide registry templates and install-context.reg before copying or
importing, and validate the native reg import result for both install and
uninstall, propagating failure instead of allowing Scoop to report success.
- Line 8: Update the removal note in the manifest entry to tell users that Scoop
automatically removes the context-menu entry during uninstall, instead of
displaying the non-pasteable `$dir` registry command; leave the existing
uninstall behavior unchanged.
---
Nitpick comments:
In `@bucket/theia-ide.json`:
- Around line 17-40: Validate the theia-ide post_install and uninstaller
registry lifecycle for both per-user and global installs. Confirm HKCU
context-menu entries are created and removed for a normal install, then confirm
the $global rewrite creates the corresponding HKLM entries and removes them
during global uninstall. Run the repository’s checkver and format validation
before merging, and correct any lifecycle failures found.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 840ba4cf-6b0c-4c75-b0e7-4768d026af35
📒 Files selected for processing (3)
bucket/theia-ide.jsonscripts/theia-ide/install-context.regscripts/theia-ide/uninstall-context.reg
|
please merge this as there is no conflict |
|
/verify |
|
All changes look good. Wait for review from human collaborators. theia-ide
|
Updated notes to clarify context menu entry removal.
|
All changes work as expected when tested locally : post_install now fails explicitly (via throw) when the registry template source directory, install-context.reg, or a non-zero reg import exit code indicates a problem, instead of silently continuing. uninstaller now also checks the reg import exit code and throws on failure. |
Added 'Open with Theia IDE' context menu entry for folders
<manifest-name[@version]|chore>: <general summary of the pull request>