Repository navigation
Leave zero vectors unchanged in span normalization instead of producing NaN - #1484
Merged
martindevans merged 1 commit intoNov 8, 2026
Merged
Conversation
martindevans
approved these changes
Nov 8, 2026
martindevans
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaxAbsoluteNormalization,TaxicabNormalization,EuclideanNormalizationandPNormalizationdivide by the norm of the vector. For an all zero vector the norm is 0, so every element becomes NaN.llama.cpp handles this case in
common_embd_normalize(common/common.cpp):so a zero vector stays all zeros. This change does the same: each method returns the vector unchanged when the norm is 0 (and the
ReadOnlySpanoverload returns a zero filled array).Added tests in
SpanNormalizationExtensionsTeststhat run every mode onnew float[3]through the array and span overloads and expect[0, 0, 0]. They failed before the fix ([NaN, NaN, NaN]) and pass now. No model needed.