QA: run_qa v1.6 form + ExplicitImports#90
Merged
ChrisRackauckas merged 1 commit intoJun 27, 2026
Merged
Conversation
Convert the hand-rolled test/qa Aqua + ExplicitImports + JET block onto the SciMLTesting 1.6 run_qa form with ExplicitImports enabled. - qa.jl: `run_qa(FindFirstFunctions; explicit_imports = true, ...)` folds the Aqua.test_all checks, the package-wide JET pass (JET.test_package via `using JET`), and all six ExplicitImports checks into one call. Aqua.test_all with defaults passes (11/11), including the ambiguities check the old block ran with recursive=false; JET.report_package returns 0 reports so the standard test_package mode is clean. No aqua_broken / jet_broken / ei_broken needed. - ExplicitImports: the only finding is all_qualified_accesses_are_public, six Base internals accessed by qualification (GC.@preserve, Base.@propagate_inbounds, Base.Order, Base.RefValue, Base.libllvm_version, Base.llvmcall). Not public API and no public replacement, so ignored via ei_kwargs (source pkg: Base). The other five EI checks pass clean. - static_analysis_tests.jl: the existing granular JET report_call hot-path type-stability checks and the AllocCheck zero-allocation assertions are kept (run_qa's package-wide JET pass does not cover specific call signatures or allocations). Still in the QA group folder, so run_tests runs them. - test/qa/Project.toml: drop ExplicitImports (transitive via SciMLTesting); keep Aqua (the ambiguities sub-check's child process needs Aqua a direct dep), JET, AllocCheck; bump SciMLTesting compat to 1.6; add Test compat. Verified locally vs released SciMLTesting 1.6.0 on Julia 1.10 (lts), 1.11, and 1.12: QA/qa.jl 18/18 + QA/static_analysis_tests.jl 34/34, 0 Fail/Error/Broken. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Brings
test/qaonto the SciMLTesting 1.6run_qaform with ExplicitImports enabled.What changed
test/qa/qa.jl(new):run_qa(FindFirstFunctions; explicit_imports = true, ei_kwargs = ...). One call now runs:Aqua.test_all(defaults; 11 checks, including ambiguities — the old block ranrecursive = false, but the default recursion also passes clean),JET.test_package, enabled byusing JET;JET.report_packagereturns 0 reports somode = :typois clean),test/qa/static_analysis_tests.jl(renamed fromqa_tests.jl): keeps the granular JETreport_callhot-path type-stability checks and the AllocCheck zero-allocation assertions.run_qa's package-wide JET pass does not cover specific call signatures or allocations, so these stay as genuine extra coverage. Still in the QA folder, sorun_tests()runs them.test/qa/Project.toml: dropExplicitImports(transitive via SciMLTesting); keepAqua(the ambiguities sub-check's child process needs Aqua as a direct dep),JET,AllocCheck; bumpSciMLTestingcompat to1.6; addTestcompat.ExplicitImports findings
no_implicit_importsno_stale_explicit_importsall_explicit_imports_via_ownersall_qualified_accesses_via_ownersall_explicit_imports_are_publicall_qualified_accesses_are_publicThe only finding is
all_qualified_accesses_are_public: six Base internals accessed by qualification —GC.@preserve,Base.@propagate_inbounds,Base.Order,Base.RefValue,Base.libllvm_version,Base.llvmcall. None are public API and none have a public replacement, so they are ignored viaei_kwargs(source pkg: Base). Noaqua_broken/jet_broken/ei_brokenneeded — nothing is known-broken.Verification
Run locally against released SciMLTesting 1.6.0 on Julia 1.10 (lts), 1.11, and 1.12, via the
run_tests()folder model withGROUP=QA:QA/qa.jl— 18/18 PassQA/static_analysis_tests.jl— 34/34 Pass🤖 Generated with Claude Code