feat(dbdr/net-peering) Add commands to configure net peerings of DB-DR#1229
Conversation
3a8dc74 to
d4d36c7
Compare
…o list the different types of endpoints of a given database (public/private rw/ro access)
d4d36c7 to
417924b
Compare
curzolapierre
left a comment
There was a problem hiding this comment.
Could you add example of output in PR's description please?
One question but overall LGTM
| SeeAlso: []string{"database-net-peerings", "database-network-configuration"}, | ||
| }.Render(), | ||
| Action: func(ctx context.Context, c *cli.Command) error { | ||
| databaseID := detect.ExtractDatabaseNameFromCommandLineOrEnv(c) |
There was a problem hiding this comment.
Question Why not using already exported helper from detect/app.go?
There was a problem hiding this comment.
The existing helper aimed at loading app + addon + database behind the DB. Here the new endpoints are DBFCC, we don't need the addon or anything, it's simply /databases/:id/network_configuration for instance, while before we were loading the addon, the hitting the db-api with the addon uuid. It's not required for these endpoints.
There was a problem hiding this comment.
Indeed, and it's currently the only one DBFCC endpoint, right?
| SeeAlso: []string{"database-net-peerings", "database-network-configuration"}, | ||
| }.Render(), | ||
| Action: func(ctx context.Context, c *cli.Command) error { | ||
| databaseID := detect.ExtractDatabaseNameFromCommandLineOrEnv(c) |
There was a problem hiding this comment.
Indeed, and it's currently the only one DBFCC endpoint, right?
Connect to the private Outscale VPC |
deps(urfave/cli) deps(go/crypto) Bump versions which were downgraded in #1229 without reason
database-network-configuration: Get networking information on a database to create a net peeringdatabase-net-peerings: List all net peeringsdatabase-net-peerings-add: Create a net peering to the database based on an outscale net peering requestdatabase-net-peerings-remove: Delete a netpeeringdatabase-endpoints: List the different types of endpoints of a given database (public/private rw/ro access)