[SYNPY-1829, SYNPY-1856, SYNPY-1858] re-enable test and fix flaky integration tests#1393
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables previously skipped integration tests for external STS storage locations now that the underlying platform issues have been addressed (per SYNPY-1829).
Changes:
- Removed the
@pytest.mark.skip(...)decorators that were disabling STS-related external storage integration tests. - Restored execution of
test_sts_external_storage_locationandtest_boto_upload_aclas part of the normal integration test run.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrewelamb
reviewed
Jun 4, 2026
linglp
commented
Jun 8, 2026
| self.schedule_for_cleanup = schedule_for_cleanup | ||
|
|
||
| @pytest.fixture(scope="class") | ||
| @pytest.fixture(scope="function") |
Contributor
Author
There was a problem hiding this comment.
linglp
commented
Jun 8, 2026
| # Update the Entity and make sure the version is incremented | ||
| entity.foo = 998877 | ||
| entity["name"] = "foobarbat" | ||
| unique_name = f"foobarbat-{uuid.uuid4()}" |
Contributor
Author
There was a problem hiding this comment.
linglp
commented
Jun 9, 2026
| raise Exception('ERROR parsing output: "' + str(output) + '"') | ||
|
|
||
|
|
||
| @pytest.mark.skip( |
Contributor
Author
There was a problem hiding this comment.
andrewelamb
approved these changes
Jun 9, 2026
Contributor
|
LGTM! |
thomasyu888
approved these changes
Jun 9, 2026
Member
There was a problem hiding this comment.
🔥 Thanks @linglp, please add all completed Jira tickets within the title too!
linglp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Other tickets:
test_command_line_clientfailed to pass after multiple reruns, so I created this: https://sagebionetworks.jira.com/browse/SYNPY-1855