Repository navigation
Pass macros to last audit in load_multiple_audits - #6160
Open
tylerjthomas9 wants to merge 1 commit into
Open
tylerjthomas9 wants to merge 1 commit into
tylerjthomas9 wants to merge 1 commit into
Conversation
Signed-off-by: Tyler Thomas <tylerjthomas9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
load_multiple_auditsdidn't passmacros,jinja_macrosormodule_pathto the last audit in a file. As a result, standalone audits using project Python or Jinja macros failed to load, which is always the case for single-audit files.Reproduction
With this fix, the plan applies and the audit passes.
Test Plan
Added
test_load_multiple_standalone_with_macros, which fails without the fix.make fast-testpasses.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO