Repository navigation
release: CableDyn 0.4.2 - #143
Merged
Merged
Conversation
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…ounded stretch (#109) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…dentical) (#115) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…t DOF (#114) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…#111) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…hread (bit-identical) (#117) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
… (bit-identical) (#119) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…t the current (#121) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…s converged (#122) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…#124) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
… residual (#123) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…nd as-laid fixes (#112) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…uency (#132) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…lidator checks the effective row (#128) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…on where it was (#131) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
… secant (#138) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…eir scripts (#118) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…length (#125) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…#137) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
… on the aggregate (#139) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…an element (#129) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…olerance (#133) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…orDyn-C files, shared cables and more (#141) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…le (#135) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…ction (#136) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…falls (#140) Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Set the version to 0.4.2 (2026-11-09) in the build, the Fortran banner, the OpenFAST module, the C API and its header, the Python package and CITATION.cff, and date the CHANGELOG section. The release note of the documentation front page names what 0.4.2 changes. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Holcombe and Bergdahl rerun with the 0.4.2 GNU Release build. Both reproduce their summaries, metrics and refinement figures byte for byte. Of the files provenance.json hashes, only the two Holcombe static profiles change, and only in their Declination and Inclination columns: the finite-EI node angles now come from the Hermite tangent, by at most 3.47 deg at the ideal clamp and 0.32 deg at a discrete module. Positions, tensions and curvatures are unchanged. The Bergdahl waveform comparison still stands from the 0.3.0 run. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
performance_records.py reruns the CableDyn rows of L5-DPC, L5-V and L5-wc with the 0.4.2 release driver (IFX) and a GNU Release build of the same source; the OrcaFlex, MoorDyn-F and MoorDyn-C rows are those of 2026-11-08. The release driver takes 1.34 / 2.37 / 4.98 s on the lazy-wave spans (0.4.1: 1.44 / 2.56 / 5.29 s), 4.30 s on the one-hour VolturnUS-S chain (4.44 s) and 0.197 s on the WD0050 chain (0.200 s). Every timed model reproduces its reference response as before, with the same solver counts. VALIDATION.md, the README and the performance pages quote the new figures. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
validation/RELEASE_0_4_2.md records the source, toolchains, pins, gates, experiment and timing results, the Windows executable gates, the clean-machine check and the hashes of the final assets (release workflow run 42620906823) and of the TestPyPI preflight distributions (run 42620911318). The CHANGELOG entry on the L5 records names the release driver they are now measured with. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CableDyn 0.4.2:
devwith #107 to #142, the version and the release records.release: CableDyn 0.4.2: the version and date (2026-11-09) in the build, the Fortran banner, the OpenFAST module, the C API and its header (patch 2, ABI 1.4 unchanged), the Python package andCITATION.cff; the dated CHANGELOG section; the release note of the documentation front page.chore(release): rerun the experiment records with 0.4.2: Holcombe and Bergdahl reproduce their summaries, metrics and refinement figures byte for byte. Only the two hashed Holcombe static profiles change, in their Declination and Inclination columns (the finite-EI node angles of fix(outputs): the tangent outputs of a finite-EI line take its tangent DOF #114: at most 3.47 deg at the ideal clamp, 0.32 deg at a discrete module).chore(release): re-time the L5 records with the 0.4.2 drivers: the release driver takes 1.34 / 2.37 / 4.98 s on the lazy-wave spans, 4.30 s on the one-hour VolturnUS-S chain and 0.197 s on the WD0050 chain, each with its reference response reproduced.Gates run on this tree (the record
validation/RELEASE_0_4_2.mdfollows once the final assets are checked):-W -n, pre-commit, the release metadata check and the tree audit pass.openfast.exe): pass, the release log identical to 0.4.1's.PATH): 13 of 13, including all 65 example decks and two bit-identicalCompMooring = 5restarts.