Repository navigation
fix(step): a time step below 1e-100 s is refused by name - #130
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
a21cb3d to
bef7e4a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
a71970e to
3610a21
Compare
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The implicit marches divide by dt^2 (the generalised-alpha inertia terms), so a tiny positive step overflowed inside the line solve: from about 1e-155 s the point route failed with "dynamic banded load/added mass returned a non-finite Jacobian" or "banded model load q/v must be finite", the finite-EI route with a cable recovery failure on non-finite prescribed motion. Down to 1e-140 s both still stepped. CD_MIN_TIME_STEP = 1e-100 s (CableDyn_Precision) now bounds every external step: a dtM row (every row, as the other OPTIONS row rules), CableDyn_Step on any route (raw lines, the point route and the aggregate), and the OpenFAST glue DT at the aggregate's and the point route's initialisation and step. The bound leaves a wide margin above the overflow and far below any useful step. The Python deck validator applies the dtM bound; the docs give it. Tests: the C API step on the point route and on raw lines refuses dt = 1e-101, 1e-160, 1e-300 and 5e-324 s by name and leaves the state unchanged, and steps at 1e-100 s; the parity tests sweep dtM against the validator and, on an EI = 0 and a finite-EI deck, the driver; test_openfast_aggregate refuses a host DT of 1e-200 s at both initialisations. The step-count test moves from dtM = 1e-300 to 1e-90, which the new bound does not refuse first. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…ns it Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
3610a21 to
50c7e4a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The time integration divides by dt². A positive dt of 1e-140 s still stepped, and from about 1e-155 s the inertia terms overflowed. A new constant
CD_MIN_TIME_STEP = 1e-100 sis enforced only at the external entry points:dtMdeck row (the Python validator mirrors the rule);CableDyn_Stepon every route;It is not applied to internal sub-steps, so recovery subdivision is unaffected.
capi.rst,options.rst,python.rstand thestepdocstring state the bound.Tests.
One existing test that targets the step-count limit moves from dtM 1e-300 to 1e-90.
CTest passes on both BLAS kernels; pytest passes.