Skip to content

Fix testWebImageWithAnimatedURL: replace dead APNG host - #367

Open
sboko83 wants to merge 1 commit into
SDWebImage:masterfrom
sboko83:fix/test-animated-url
Open

sboko83 wants to merge 1 commit into
SDWebImage:masterfrom
sboko83:fix/test-animated-url

Conversation

@sboko83

@sboko83 sboko83 commented Oct 9, 2026 •

Copy link
Copy Markdown

Problem

WebImageTests.testWebImageWithAnimatedURL loads https://apng.onevcat.com/assets/elephant.png.
That host no longer resolves (NSURLErrorDomain -1003), so the test fails on iOS, macOS and tvOS
for every PR (see the CI run of #366).

Fix

Point the test at TestImageAnimated.apng from the SDWebImage repository
(raw.githubusercontent.com/SDWebImage/SDWebImage/master/Tests/Tests/Images/), an animated PNG
with 101 frames hosted under the same organization. Test logic is unchanged.

Summary by CodeRabbit

  • Tests
    • Updated an animated-image test to load its sample APNG from a different source.

- apng.onevcat.com no longer resolves, testWebImageWithAnimatedURL fails on every platform
- use TestImageAnimated.apng from the SDWebImage repository instead
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1166c822-7a78-4044-a175-c8126d147c40

📥 Commits

Reviewing files that changed from the base of the PR and between d1f7b2b and 61b47f6.


📒 Files selected for processing (1)
  • Tests/WebImageTests.swift

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.



📝 Walkthrough

Walkthrough

The animated-image test now loads its APNG from the SDWebImage GitHub repository. Its assertions and test flow are unchanged.

Changes

Animated-image test

Layer / File(s) Summary
Update animated-image test source
Tests/WebImageTests.swift
The test now loads TestImageAnimated.apng from the SDWebImage GitHub repository. Its assertions and test flow are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix


Merge Risk: ⚪ Minimal · up to 61b47

No verified merge-blocking issue remains. The test still depends on an external asset whose response was not confirmed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: replacing the unavailable APNG host used by testWebImageWithAnimatedURL.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR


🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant