Repository navigation
Conversation
- apng.onevcat.com no longer resolves, testWebImageWithAnimatedURL fails on every platform - use TestImageAnimated.apng from the SDWebImage repository instead
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe animated-image test now loads its APNG from the SDWebImage GitHub repository. Its assertions and test flow are unchanged. ChangesAnimated-image test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No verified merge-blocking issue remains. The test still depends on an external asset whose response was not confirmed. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
WebImageTests.testWebImageWithAnimatedURLloadshttps://apng.onevcat.com/assets/elephant.png.That host no longer resolves (
NSURLErrorDomain -1003), so the test fails on iOS, macOS and tvOSfor every PR (see the CI run of #366).
Fix
Point the test at
TestImageAnimated.apngfrom the SDWebImage repository(
raw.githubusercontent.com/SDWebImage/SDWebImage/master/Tests/Tests/Images/), an animated PNGwith 101 frames hosted under the same organization. Test logic is unchanged.
Summary by CodeRabbit