ParseDepends: keep Windows drive-letter paths in depfiles - #4904
Merged
Merged
Conversation
Collaborator
|
This seems a valid concern. |
Replace inline comments with a proper docstring to document the purpose of skipping Windows drive-letter colons when splitting make-style depfile lines.
Contributor
|
Looks good to me. I just pushed a minor change for the new function where I changed the comment on the functions functionality to be a docstring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment.ParseDependssplit each make-style depfile line on the first colon. A Windows line such asC:\build\foo.o: C:\src\foo.cwas therefore treated as targetCand the rest as dependencies.Skip colons that are drive letters (
C:\/C:/) and keep the existingtarget.split()/depends.split()behaviour for Unix-style files.The added unit test fails on the unpatched tree and passes with the change.
Tested:
python runtest.py SCons/EnvironmentTests.py