Repository navigation
Bell element - #111
Draft
jacobmerson wants to merge 25 commits into
Draft
Bell element#111jacobmerson wants to merge 25 commits into
jacobmerson wants to merge 25 commits into
Conversation
This performs interpolation to target elements. We use ownership to avoid having multiple element write to the same dofs on shared entities. This interpolation capability will be used to support generic coordinate field initialization for higher order elements.
cannot have lambdas in function with auto return type with cuda
To support non-isoparametic elements, we split the evaluation of the nodal coefficients and the multiplication with the shape functions
MappedElement composes a field element with a geometry element over the coordinate field (see SCOREC#100)
In the case of affine (straight sided) and isoparametric elements we will want to take compile-time optimized code paths so the performance of a MappedElement is similar to a base FieldElement
The TestHarness runs tests with all available controllers and mesh types. This will improve generalizability as we add additional mesh types e.g., mixed and new element types e.g., quads
This combines the jacobian tests into a single test case
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will need quite a bit of work to full vet the implementation. However, it does demonstrate the use of the
MappedElementclass.Based on where we are with this, I'd guess it's at least a week or two of @Sichao25 time to fully review due to the complexity of the mapping. Fortunately we can use the FIAT definition as a basis to test against.