Conversation
|
/runtests |
|
Build Log |
Moving the file up sounds good to me. It can be a minor version bump if the
I agree with the logic here.
The |
|
Shouldn't this PR target develop? |
|
Thank you. regarding use of |
|
Looks good. Will there be a tag/release or will you wait to bundle it with anything else? |
|
Good point. This would be a minor version bump given that is is backward compatible. I'll push a commit to update the version but don't think we need to tag/release for this. |
|
/runtests |
|
Build Log |
|
/runtests |
|
Build Log |
SimModSuite 2026.0-260411 replaces
GM_createFromAssemblyModel()withModelBuilderAPIs. This PR makes those changes and moves and renames the header that provides the SimModSuite version to the top level dir of the repo (apf_simConfig.h->simModSuiteConfig.h). This is a breaking change... but I don't know if anyone will care unless they are using our header to determine which SimModSuite APIs to call etc.A couple alternatives:
apf_sim/apf_simConfig.h.inand have other packages depend on it... this seems messy as gmi_sim doesn't/shouldn't depend on apf_simSimModSuiteVersion.hheader - still a breaking change, but better in the long run to not rely on our own header for the same functionality@bobpaw Thoughts?