Repository navigation
[INTERNAL] Improve handling of non-empty, non-manifest JSON files - #1248
Merged
d3xter666 merged 1 commit intoOct 23, 2026
Merged
Conversation
d3xter666
force-pushed
the
refactor-improve-json-handling-of-empty-non-manifest-files
branch
from
October 22, 2026 08:04
7dcd511 to
acd4deb
Compare
RandomByte
previously approved these changes
Oct 22, 2026
d3xter666
force-pushed
the
refactor-improve-json-handling-of-empty-non-manifest-files
branch
2 times, most recently
from
October 23, 2026 08:26
3d727fa to
7675b07
Compare
JIRA: CPOUI5FOUNDATION-1046 This PR steps over and extends UI5/cli#1667. The reason behind this change is that besides it's not related to manifest.json parsing, it follows the same pattern for handling empty JSON files and providing more context in the error message. Thus, we handle this edge case of parsing empty JSON files the same.
d3xter666
force-pushed
the
refactor-improve-json-handling-of-empty-non-manifest-files
branch
from
October 23, 2026 08:37
7675b07 to
1cf27e7
Compare
RandomByte
approved these changes
Oct 23, 2026
d3xter666
deleted the
refactor-improve-json-handling-of-empty-non-manifest-files
branch
October 23, 2026 08:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downport of UI5/cli#1668
JIRA: CPOUI5FOUNDATION-1046
This PR steps over and extends #1249.
The reason behind this change is that besides it's not related to manifest.json parsing, it follows the same pattern for handling empty JSON files and providing more context in the error message.
Thus, we handle this edge case of parsing empty JSON files the same.
Note: There are special cases where an empty JSON is expected and is handled explicitly. Those are not touched. i.e. https://github.com/UI5/cli/blob/main/packages/builder/lib/processors/jsdoc/lib/createIndexFiles.js#L66-L68