Repository navigation
fix: shut down gracefully on SIGTERM - #481
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a container the gateway runs as PID 1. Python installs no SIGTERM handler, and the kernel ignores a default-action SIGTERM for PID 1, so
docker stopwaited 10 s and then sent SIGKILL. Thefinallythat closes the SAIC API client (#479) and other cleanup never ran.run_until_terminated()insrc/shutdown.py. On SIGTERM it cancels the main task, sofinallyblocks run, and the process exits with code 0. Exceptions and other cancellations (such as Ctrl-C) are not swallowed. If a handler can't be installed on the platform, it is skipped.src/main.py..git/,.claude/andtests/to.dockerignoreto keep them out of the build context.README.mdstays, becausepyproject.tomldeclares it as the readme.Tested: five unit tests (including a real SIGTERM), and a subprocess run where SIGTERM runs the cleanup and exits with code 0. Ruff, mypy and the full suite pass (323 tests). Not tested: a real
docker stopagainst the built image.