Skip to content

Cover case where Emap returns != 1 row #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyestein merged 1 commit into from
Oct 2, 2026
Merged

Cover case where Emap returns != 1 row #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions tests/test_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ def get_expected_write_frame_kwargs(self) -> dict:
return expected


DbStatus = Literal["ok", "no_connect", "wrong_number_rows"]


@pytest.mark.parametrize(
# only affect LF tests so is redundant for HF (which is always numeric)
# "both" is a form of bad data which we should reject
Expand All @@ -148,10 +151,7 @@ def get_expected_write_frame_kwargs(self) -> dict:
"opt_out",
[True, False],
)
@pytest.mark.parametrize(
"db_connect_failure",
[True, False],
)
@pytest.mark.parametrize("db_status", ["ok", "no_connect", "wrong_number_rows"])
@pytest.mark.parametrize(
"bad_data_type",
# 0 is not bad data, 1,2,3 are various different kinds of bad data
Expand All @@ -162,18 +162,20 @@ def test_controller_callback(
lf_value_type,
fake_data_class,
opt_out,
db_connect_failure,
db_status: DbStatus,
bad_data_type,
):
) -> None:
# Certain combinations of test just don't make sense
if fake_data_class == FakeHFData and lf_value_type != "numeric":
pytest.skip()

emap_db_mock = Mock()
if db_connect_failure:
if db_status == "no_connect":
emap_db_mock.get_matched_mrn.side_effect = ConnectionError(
"mock database error"
)
elif db_status == "wrong_number_rows":
emap_db_mock.get_matched_mrn.side_effect = ValueError()
else:
emap_db_mock.get_matched_mrn.return_value = ("mrn", "nhsno", "csn", opt_out)
monkeypatch.setattr("controller.db_pg.starDB", Mock(return_value=emap_db_mock))
Expand Down Expand Up @@ -217,11 +219,23 @@ def test_controller_callback(
emap_db_mock.get_matched_mrn.assert_not_called()
channel_mock.basic_reject.assert_called_once_with(delivery_tag, False)
channel_mock.basic_ack.assert_not_called()
elif db_connect_failure:
elif db_status == "no_connect":
# if the DB lookup failed, we should not write anything and requeue the message
write_frame_mock.assert_not_called()
channel_mock.basic_reject.assert_called_once_with(delivery_tag, True)
channel_mock.basic_ack.assert_not_called()
elif db_status == "wrong_number_rows":
# if the DB lookup return != 1 row, we still expect to write the data,
# but with unknown csn, mrn
expected_write_frame_kwargs = fake_data_obj.get_expected_write_frame_kwargs()
expected_write_frame_kwargs.update(
csn="unmatched_csn",
mrn="unmatched_mrn",
)
write_frame_mock.assert_called_once_with(**expected_write_frame_kwargs)
# we assume this to be a non-transient error, so reject without requeue
channel_mock.basic_reject.assert_called_once_with(delivery_tag, False)
channel_mock.basic_ack.assert_not_called()
elif opt_out:
# patient has opted out, dump the message
write_frame_mock.assert_not_called()
Expand Down
Loading