Repository navigation
streebog: fix stale doc comments in consts - #933
Merged
Merged
Conversation
`C64` stopped being `[[u64; 8]; 12]` in RustCrypto#925, when the internal `U512` type was introduced, but its doc comment still claims the iteration constants are represented as `[u64; 8]`. The module docs also point at `table::SHUFFLED_LIN_TABLE`, although the crate has no `table` module: the table is generated in this very module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two comments in
streebog/src/consts.rsno longer match the code:table::SHUFFLED_LIN_TABLE, but there is notablemodule in the crate.SHUFFLED_LIN_TABLEis generated in thismodule, so the path is dropped.
C64is documented as[u64; 8], which was true until streebog: tweak internal implementation #925 replacedthe
[[u64; 8]; 12]type with[U512; 12]. The comment now claims asingle 8-word constant where there are 12 iteration constants.
Comment-only change; no functional difference.
cargo test -p streebogpasses (7 tests + 1 doctest).