Skip to content

gss-api: remove x509-cert dependency - #2435

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
dishmaker:dishmaker/gss-api_remove_x509_cert
Sep 22, 2026
Merged

tarcieri merged 1 commit into
RustCrypto:masterfrom
dishmaker:dishmaker/gss-api_remove_x509_cert

Conversation

@dishmaker

Copy link
Copy Markdown
Contributor
$ cargo clippy --version
clippy 0.1.100 (1303417c41 2026-09-21)
$ cargo clippy --all --all-features

warning: unused dependency `x509-cert`
  --> gss-api/Cargo.toml:21:1
   |
21 | x509-cert = { version = "0.3", default-features = false }

warning: unused dependency `x509-cert`
  --> gss-api/Cargo.toml:21:1
   |
21 | x509-cert = { version = "0.3", default-features = false }
@dishmaker
dishmaker force-pushed the dishmaker/gss-api_remove_x509_cert branch from 3b96547 to a9b1d25 Compare September 22, 2026 19:40
@dishmaker
dishmaker marked this pull request as ready for review September 22, 2026 19:43
Comment thread gss-api/Cargo.toml

[dependencies]
der = { version = "0.8", features = ["oid", "alloc"] }
der = { version = "0.8", features = ["oid", "alloc", "derive"] }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this about?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derive feature was enabled through x509-cert.
It did not compile with just x509-cert removed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah

@tarcieri
tarcieri merged commit 6691ba5 into RustCrypto:master Sep 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants