Skip to content

pkcs8: replace BitStringLike with blanket impl der::asn1::AsBitStringRef - #2434

Open
dishmaker wants to merge 2 commits into
RustCrypto:masterfrom
dishmaker:dishmaker/pkcs8_use_asbitstringref
Open

pkcs8: replace BitStringLike with blanket impl der::asn1::AsBitStringRef#2434
dishmaker wants to merge 2 commits into
RustCrypto:masterfrom
dishmaker:dishmaker/pkcs8_use_asbitstringref

Conversation

@dishmaker

@dishmaker dishmaker commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Replaces internal BitStringLike with der::asn1::AsBitStringRef
introduced in:

@dishmaker
dishmaker marked this pull request as ready for review September 22, 2026 19:38
@tarcieri

tarcieri commented Sep 22, 2026

Copy link
Copy Markdown
Member

pkcs8 already has a stable v0.11.0 release so this is a breaking change. Maybe add a TODO to switch to AsBitStringRef or AsRef?

@dishmaker dishmaker closed this Sep 22, 2026
@dishmaker dishmaker mentioned this pull request Sep 22, 2026
Closed
@tarcieri

tarcieri commented Sep 22, 2026

Copy link
Copy Markdown
Member

Hmm, actually I think this could work if you add a blanket impl and deprecation

@dishmaker dishmaker reopened this Sep 22, 2026
@dishmaker
dishmaker force-pushed the dishmaker/pkcs8_use_asbitstringref branch from 385a210 to a770d72 Compare September 22, 2026 22:27
@dishmaker

dishmaker commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

I changed the fn as_bit_string_ref to be consistent with:

@dishmaker dishmaker changed the title pkcs8: use der::asn1::AsBitStringRef trait pkcs8: replace BitStringLike with blanket impl der::asn1::AsBitStringRef Sep 22, 2026
tarcieri
tarcieri approved these changes Sep 22, 2026
View reviewed changes

@tarcieri tarcieri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this is the best we can do for now

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dishmaker @tarcieri