Closed
Fix camelCase kwarg bug: instructorTriggered → instructor_triggered in rsmanage#1351
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: bnmnetp <51115+bnmnetp@users.noreply.github.com>
…tion Co-authored-by: bnmnetp <51115+bnmnetp@users.noreply.github.com>
Co-authored-by: bnmnetp <51115+bnmnetp@users.noreply.github.com>
Co-authored-by: bnmnetp <51115+bnmnetp@users.noreply.github.com>
Co-authored-by: bnmnetp <51115+bnmnetp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code as per review comment
Fix camelCase kwarg bug: instructorTriggered → instructor_triggered in rsmanage
Aug 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (1)
components/rsptx/lti1p3/core.py:89
- When
instructor_triggered=Trueand the assignment has aduedate,_submitted_at_for_scorealways usesduedate - 1 minuteforsubmission.submittedAt. If an instructor triggers a push before the deadline, this can produce asubmittedAttimestamp that is in the future relative to the gradetimestamp, which is inconsistent and may be rejected or misinterpreted by the LMS. Consider clamping to the score timestamp whenduedate - 1 minuteis later than the score timestamp.
def _submitted_at_for_score(
rs_assignment: Assignment, score_timestamp: str, instructor_triggered: bool
) -> str:
if not instructor_triggered:
return score_timestamp
if rs_assignment.duedate is None:
return score_timestamp
return _format_lti_timestamp(rs_assignment.duedate - datetime.timedelta(minutes=1))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recompute_totals_detailacceptsinstructor_triggered(snake_case), but the call inbases/rsptx/rsmanage/core.pypassedinstructorTriggered=True(camelCase), which would raiseTypeError: got an unexpected keyword argumentat runtime whenfixtotalsis invoked.Changes
bases/rsptx/rsmanage/core.py: Rename kwarginstructorTriggered=True→instructor_triggered=Trueat therecompute_totals_detail(...)call site infixtotals.